chore(deps): update dependency microsoft.net.test.sdk to 18.0.1 #3071
Conversation
trusted-contributions-gcf
bot
added
the
kokoro:force-run
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Microsoft.NET.Test.Sdk dependency from version 18.0.0 to 18.0.1 across three test projects. This is a patch update that fixes an issue with code coverage tooling, so it's a safe and recommended change. While the update itself is correct, I've identified an opportunity to improve the project's long-term maintainability by centralizing NuGet package version management. My review includes a detailed suggestion on how to achieve this using a Directory.Build.props file, which would simplify future dependency updates and ensure consistency across the solution.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> |
There was a problem hiding this comment.
While this version update is correct, I've noticed that this dependency and others (like xunit) are declared with explicit versions in multiple .csproj files. This can make dependency management cumbersome and error-prone.
To improve maintainability and ensure version consistency across all test projects, you could centralize package version management. A common way to achieve this in .NET projects is by using a Directory.Build.props file at the root of your solution or a shared parent directory. This would also be a good place to standardize other properties like LangVersion, which is currently inconsistent across projects (latest vs 10.0).
For example, you could create a Directory.Build.props file with the following content:
<Project>
<PropertyGroup>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="Xunit.Combinatorial" Version="1.6.24" />
<!-- Note: Aligning xunit.runner.visualstudio version -->
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
<PackageVersion Include="Xunit.SkippableFact" Version="1.5.23" />
<PackageVersion Include="BouncyCastle.Cryptography" Version="2.6.2" />
<!-- etc. for other common packages -->
</ItemGroup>
</Project>Then, in your .csproj files, you can omit the Version attribute from the <PackageReference> elements. MSBuild will automatically use the versions defined in Directory.Build.props.
<PackageReference Include="Microsoft.NET.Test.Sdk" />This would centralize version definitions, making future updates much simpler and ensuring consistency. As part of this, you could align the xunit.runner.visualstudio version, which is currently 2.4.3 in this project but 2.8.2 in Google.Apis.IntegrationTests.csproj.
2 participants
This PR contains the following updates:
18.0.0->18.0.1Release Notes
microsoft/vstest (Microsoft.NET.Test.Sdk)
v18.0.1What's Changed
Fixing an issue with loading covrun64.dll on systems that have .NET 10 SDK installed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/code-coverage-dynamic-native-instrumentation
Internal changes
Full Changelog: microsoft/vstest@v18.0.0...v18.0.1
Configuration
📅 Schedule: Branch creation - "before 8am every weekday" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.